Fix timeout evaluations getting positive fitness#446
Open
bud333 wants to merge 1 commit intoalgorithmicsuperintelligence:mainfrom
Open
Fix timeout evaluations getting positive fitness#446bud333 wants to merge 1 commit intoalgorithmicsuperintelligence:mainfrom
bud333 wants to merge 1 commit intoalgorithmicsuperintelligence:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix timeout evaluation paths so timed-out programs cannot receive positive fitness.
In the current behavior, timeout results may omit
combined_score, and the fallback fitness logic can incorrectly treat boolean flags liketimeout=Trueas numeric values. This allows failed or timed-out programs to receive a positive fitness score.For example, a timeout result like
{"error": 0.0, "timeout": True}could previously receive a positive fallback fitness becauseTruewas treated as1.0. This change makes timeout paths returncombined_score=0.0explicitly and excludes boolean flags from fallback fitness aggregation.Changes
combined_score=0.0for direct evaluation timeoutscombined_score=0.0for cascade stage timeoutserrormessage for timeout casesWhy
This fixes a case where timed-out programs could receive positive fitness when timeout results omitted
combined_scoreand boolean flags were treated as numeric values in fallbackfitness calculation.
Verification
Passed:
export OPENAI_API_KEY=test-key-for-unit-tests && python -m unittest tests.test_evaluator_timeout tests.test_metrics_utilsexport OPENAI_API_KEY=test-key-for-unit-tests && python -m unittest discover tests